[opus] [PATCH 1/1] Updated opus_types.h to correctly support 8 and 64 bit types.

Simon Jackson si at sonocent.com
Wed Jun 3 09:50:10 PDT 2015

Indentation looked ok to me, its probably due to my editor. I will fix it in vim and re-submit it.

Didn’t know that, will fix. 

No they haven’t all been tested, however I consulted documentation available for each of the platforms on the internet and copied the ogg headers when in doubt.

> On 3 Jun 2015, at 17:43, Mark Harris <mark.hsj at gmail.com> wrote:
> Simon Jackson wrote:
>> +   typedef char opus_int8;
> ISO C allows the "char" type to be either signed or unsigned.  It is
> even a compiler switch on some compilers.  Changing this from "signed
> char" to plain "char" breaks when "char" is unsigned.
> Several of the changed lines introduce inconsistent indentation or
> spaces at the end of the line, which is somewhat unfitting for a patch
> whose purpose is to improve consistency.
> Have each of the affected #elif sections been tested on the platforms
> where that section is compiled?
> - Mark

More information about the opus mailing list