[opus] [PATCH 1/1] Updated opus_types.h to correctly support 8 and 64 bit types.
jmvalin at jmvalin.ca
Wed Jun 3 09:58:45 PDT 2015
A more important issue here is that not all platforms we target are even
8-bit addressable (e.g. the TI C5x family). That is why I've preferred
using "unsigned char" (or in some places signed char) when the idea is
just to use the smallest size possible on the platform. As for 64 bits
types, it's been purposefully defined as "long long" because on some
platforms (e.g. C55x again) long long is just 40 bits, which is just
enough for what we need.
Simon, is your patch designed to fix a particular issue with types on a
certain platform or is it more of a "general cleanup" type?
On 03/06/15 12:43 PM, Mark Harris wrote:
> Simon Jackson wrote:
>> + typedef char opus_int8;
> ISO C allows the "char" type to be either signed or unsigned. It is
> even a compiler switch on some compilers. Changing this from "signed
> char" to plain "char" breaks when "char" is unsigned.
> Several of the changed lines introduce inconsistent indentation or
> spaces at the end of the line, which is somewhat unfitting for a patch
> whose purpose is to improve consistency.
> Have each of the affected #elif sections been tested on the platforms
> where that section is compiled?
> - Mark
> opus mailing list
> opus at xiph.org
More information about the opus