[opus] [PATCH 1/1] Updated opus_types.h to correctly support 8 and 64 bit types.

Mark Harris mark.hsj at gmail.com
Wed Jun 3 09:43:50 PDT 2015

Simon Jackson wrote:
> +   typedef char opus_int8;

ISO C allows the "char" type to be either signed or unsigned.  It is
even a compiler switch on some compilers.  Changing this from "signed
char" to plain "char" breaks when "char" is unsigned.

Several of the changed lines introduce inconsistent indentation or
spaces at the end of the line, which is somewhat unfitting for a patch
whose purpose is to improve consistency.

Have each of the affected #elif sections been tested on the platforms
where that section is compiled?

 - Mark

More information about the opus mailing list