[opus] [PATCH] Refactor silk_LPC_analysis_filter() & Optimize celt_fir_permit_overflow() for ARM NEON

[Linfeng Zhang]

Thank Ulrich!

Yes, but when the jump table is active, the platform specific optimization
functions could not be inlined.

On Wed, Mar 1, 2017 at 11:27 PM, Ulrich Windl <
Ulrich.Windl at rz.uni-regensburg.de> wrote:

> Hi!
>
> I'm not deep i the code, but from my experience even older gcc (4.3.4)
> does function inlining at -O2, and at -O3 it inlines almost any function
> inside one module. Once I even let it inline across modules (-combine). I'm
> not talking about explicit inline functions; just about automatic
> optimization.
> So did you check that frequent function calls actually happen? I'm a bit
> afraid that after all those optimizations suggested the code may be rather
> hard to understand. I think compilers should do the dirty work (i.e.:
> optimizing and inlining). Sometimes "static" and "const" attributes help
> the compiler to optimize...
>
> Regards,
> Ulrich
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.xiph.org/pipermail/opus/attachments/20170302/5d460825/attachment.html>