[opus] Patches for adding 120 ms encoding

Felicia Lim flim at google.com
Fri Jun 10 14:19:00 UTC 2016


Hi, I wondered if are there any further thoughts on these patches?

Thanks,
Felicia

On Thu, Jun 2, 2016 at 2:13 PM Felicia Lim <flim at google.com> wrote:

> OK, I've amended the second patch and also added 80 and 100 ms.
>
> Thanks,
> Felicia
>
>
> On Thu, Jun 2, 2016 at 7:20 AM Jean-Marc Valin <jmvalin at jmvalin.ca> wrote:
>
>> On 06/01/2016 02:06 PM, Felicia Lim wrote:
>> > That was my intention with refactoring out the subframe encoding and
>> > repacketizing bit. Or do you mean I should merge the explicit check for
>> > 120 ms frame and the existing checks for 40/60 ms wideband?
>>
>> What I mean is that this line in opus_encoder.c:
>>
>> if (frame_size > st->Fs/50 && (st->mode == MODE_CELT_ONLY ||
>> st->bandwidth > OPUS_BANDWIDTH_WIDEBAND))
>>
>> can probably be extended to also cover 80/100/120 ms. One difference is
>> that it would also need to trigger for SILK-only > 60 ms.
>>
>> Cheers,
>>
>>         Jean-Marc
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.xiph.org/pipermail/opus/attachments/20160610/d9b0cfef/attachment.html>


More information about the opus mailing list