[Vorbis-dev] various patches from Mandrakelinux package

[Frederik Himpe]

<200408021758.45888.fhimpe at telenet.be>
<200408031337.47283.msmith at xiph.org>
Message-ID: <200408030922.09098.fhimpe at telenet.be>

On Tuesday 03 August 2004 05:37, Michael Smith wrote:

> > > On Monday 02 August 2004 16:10, Frederik Himpe wrote:
> > > > libvorbis-1.1-aliasing.patch

> Uses the ieee754.h header unconditionally. Is this header present
> everywhere? Needs (at least) testing on linux (I assume you've done this
> :-) and windows (which you probably haven't).
>
> I'd guess it'd be easier to import the definitions from that header
> directly into the file, if it isn't a header you can rely on existing
> everywhere.
>
> Why is the patch needed? From the filename, I'm guessing it's something to
> do with aliasing rules. Was this actually causing problems in practice?
> Does this version still compile to efficient code (the whole reason for
> those functions was to be very fast) with (at least) gcc and msvc?

I am CC-ing Gwenole Beauchesne, the author of this patch, who will certainly
be able to answer these questions. I have only ported his patch to current
1.1 svn. I presume that this patch maybe makes it safe to use
-fstrict-aliasing.

Frederik