[vorbis-dev] More errors in the file format specification Was: Test files for decoder implementation

[Tor-Einar Jarnbjo]

Hi, 

I've found some more errors in the file format specification (or 
at least points, where the specification and actual libvorbis implementation 
mismatch):

- Floor 1 / curve computation / step 1: amplitude value synthesis

21) vector [floor1_final_Y] element [i] = 
  [predicted] - (([val] - 1) divided by  2 using integer division)

hould be:

21) vector [floor1_final_Y] element [i] = 
  [predicted] - (([val] + 1) divided by  2 using integer division)

<p>- in the function render_line

11) [ady] = [ady] - [base] * [adx]

hould be:

11) [ady] = [ady] - absolute value of [base] * [adx]

<p>Also, the parameter order of render_point(x0,x1,y0,y1,X) and render_line(x0,
y0, x1, y1, v) is not consistent, and the references to the render_line 
function use different ordering:

- Floor 1 / curve computation / step 2: curve synthesis

8) render_line( [lx], [hx], [ly], [hy], [floor] )
12) render_line( [hx], [hy], [n], [hy], [floor] )

<p><p>Tor

<p><p>===================================================================
EASY and FREE access to your email anywhere: http://Mailreader.com/
===================================================================

<p>--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.