[vorbis-dev] More errors in the file format specification Was: Test files for decoder implementation

Tor-Einar Jarnbjo Tor-Einar_Jarnbjo at grosch-link.de
Mon Sep 23 05:48:17 PDT 2002



And right away a few more:

When filling the vector [floor1_final_Y] in floor 1 / amplitude value 
synthesis, libvorbis is just replacing the values in the vector [floor1_Y] 
instead of filling a new vector. If there is a reason for allocating 
and using a new vector instead of just modifying [floor1_Y] the step

5) [predicted] = render_point( 
  vector [floor1_X_list] element [low_neighbor_offset],
  vector [floor1_X_list] element [high_neighbor_offset],
  vector [floor1_Y] element [low_neighbor_offset],
  vector [floor1_Y] element [high_neighbor_offset],
  vector [floor1_X_list] element [i] )

must read:

5) [predicted] = render_point( 
  vector [floor1_X_list] element [low_neighbor_offset],
  vector [floor1_X_list] element [high_neighbor_offset],
  vector [floor1_final_Y] element [low_neighbor_offset],
  vector [floor1_final_Y] element [high_neighbor_offset],
  vector [floor1_X_list] element [i] )

<p>Also, in the same block the following step:

19) vector [floor1_final_Y] element [i] = 
  [predicted] - ([val] - [lowroom]) - 1

must read:

19) vector [floor1_final_Y] element [i] = 
  [predicted] - [val] + [hiroom] - 1

<p><p>Tor

<p><p><p>===================================================================
EASY and FREE access to your email anywhere: http://Mailreader.com/
===================================================================

<p>--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.



More information about the Vorbis-dev mailing list