[vorbis-dev] patch for title(?) segmentation fault
Daniel Resare
noa at metamatrix.se
Sun Jul 8 01:28:45 PDT 2001
On Sat, Jul 07, 2001 at 07:07:24PM -0600, Bill Currie wrote:
> oggenc -b 128 -d 1985 -N 01 -t "Black Planet" -l "First and Last and Always" -a "Sisters of Mercy" track01.cdda.wav
>
> segs in free in simple_utf8_encode. I tracked it down to a mis-calculated
> buffer size for malloc. I've attached the patch that fixes it (for me:).
>
> The only problem I have with the rest of the code is figuring out how the
> terminating 0 (null, whatever:) gets into unicode, I can't see anywhere that
> sets it, so I'm suprised make_utf8_string doesn't cause any problems.
>
> Bill
> --
> Leave others their otherness. -- Aratak
Wrote that, found that, fixed that. It seems liked Michael applied an
early version of my patch. I have since then fixed two serious bugs which
are both announced on the webpage http://noa.tm/vorbis-utf8/ and on this
list (http://www.xiph.org/archives/vorbis-dev/200104/0009.html and
http://www.xiph.org/archives/vorbis-dev/200105/0193.html) I will send in
a patch against cvs later today, if no one beats me :)
cheers/daniel
--
begin:vcard fn:Daniel Resare tel;cell:+46739442044 tel;work:+468332040
adr;work:Scheelegatan 36; 112 28; Stockholm; Sweden end:vcard
pgp fingerprint: 8D97 F297 CA0D 8751 D8EB 12B6 6EA6 727F 9B8D EC2A
--- >8 ----
List archives: http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body. No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.
More information about the Vorbis-dev
mailing list