[vorbis-dev] patch for title(?) segmentation fault

[Monty]

On Sat, Jul 07, 2001 at 07:07:24PM -0600, Bill Currie wrote:
> oggenc -b 128 -d 1985 -N 01 -t "Black Planet" -l "First and Last and Always" -a "Sisters of Mercy" track01.cdda.wav
> 
> segs in free in simple_utf8_encode. I tracked it down to a mis-calculated
> buffer size for malloc. I've attached the patch that fixes it (for me:).
> 
> The only problem I have with the rest of the code is figuring out how the
> terminating 0 (null, whatever:) gets into unicode, I can't see anywhere that
> sets it, so I'm suprised make_utf8_string doesn't cause any problems.

Part of the confusion may be that Vorbis comment values are not '\0'
terminated; you can tell libvorbis to also encode a '\0', but that's
part of the 'content' of the string as far as Vorbis is concerned.
Comment fields are length encoded, 8-bit clean and as such, '\0' has
no special meaning.

Monty

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.