[vorbis-dev] Re: bug report for oggenc in CVS: vorbis-tools/oggenc/encode.c

[Cameron Simpson]

On Mon, Dec 03, 2001 at 09:24:24PM +1100, Michael Smith <msmith at labyrinth.net.au> wrote:
| >Now, backtracing through vorbis/lib, it seems to me that the inner eos is
| >being used to stop the output when we've temporarily run out of input,
| >which is fine. But the SAME eos flag is used to stop the outer loop. I
| >feel that either eos should be reset after the inner loop, or that there
| >should be a separate eos-like flag used for the inner loop.
| 
| The eos flag is set once an output page is produced that has the eos flag
| set - this flag only gets set once all input has been consumed.

That would appear not to be the case for me; I will have to investigate
further.

| The inner
| loop stops on eos once the encode is complete - usually, it breaks out. 
| Then the right thing to do is to also finish the outer loop - which is what
| the code does.

Then surely the outer loop is not needed at all?

| Not sure why you're getting short encodes though - are you encoding from
| stdin?

Yes.

| On windows?

No, Linux with 1.0rc2 (shipped with RedHat 7.2).

I will try to set up a trivial test case, but it happens with damn
near every CD I've been using so far. The source data is obtained with
cdparanoia.

-- 
Cameron Simpson, DoD#743        cs at zip.com.au    http://www.zip.com.au/~cs/

Now _I_ am the butcher with the warest heart! Ya wanna the see the knives I
used to carve it with, its over there in the oven!	- J Teague

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.