[vorbis-dev] bug report for oggenc in CVS: vorbis-tools/oggenc/encode.c

[Michael Smith]

>Now, backtracing through vorbis/lib, it seems to me that the inner eos is
>being used to stop the output when we've temporarily run out of input,
>which is fine. But the SAME eos flag is used to stop the outer loop. I
>feel that either eos should be reset after the inner loop, or that there
>should be a separate eos-like flag used for the inner loop.

The eos flag is set once an output page is produced that has the eos flag
set - this flag only gets set once all input has been consumed. The inner
loop stops on eos once the encode is complete - usually, it breaks out. 
Then the right thing to do is to also finish the outer loop - which is what
the code does.

Not sure why you're getting short encodes though - are you encoding from
stdin? On windows? I had a report a while ago about short encodes under
those circumstances, but couldn't reproduce it here. 

Michael

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.