[vorbis-dev] XMMS plugin update

Monty xiphmont at xiph.org
Sat Nov 13 05:13:44 PST 1999



Tony,

I committed a new version of the XMMS plugin.  This is a cleaned up and
debugged version of the code you sent me with the conversion to the vorbisfile
app library.

At this point, it properly handles chaining (try concatenating two vorbis files
with different serial numbers to see it work).  The code also got alot smaller
as alot of the hairy stuff is now done by vorbisfile.a.

In the process, I found three vorbisfile library bugs (yay!).  The simple one I
fixed. Bug number two (a spurious error return from ov_read at the beginning of
a logical bitstream) won't affect the plugin, but if you see it when debugging,
don't be alarmed as I'll fix it soon.  The third is that the vorbisfile lib is
not thread safe.  That doesn't affect things yet, but seeking will likely
involve async access/manipulation of the OggVorbis_File struct.  We need to
decide if threadsafing vorbisfile.a is the right thing to do (it'll be annoying
to apps that aren't threaded) or if locking things in the XMMS plugin is the
right thing to do (the threading synchronization system in XMMS is suboptimal
for this. Spinlocks with waits would be a poor way to locksafe the structure).

Monty

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/



More information about the Vorbis-dev mailing list