[Speex-dev] Obtaining loudness information in 1.2beta2

Jean-Marc Valin jean-marc.valin at usherbrooke.ca
Tue Oct 30 01:59:05 PDT 2007


Applied with minor change. Thanks

	Jean-Marc

Mihai Balea a écrit :
> 
> On Oct 25, 2007, at 7:45 PM, Jean-Marc Valin wrote:
> 
>> I'm in favor of the idea, but not of the current implementation. There
>> are two problems:
>> 1) The st->loudness parameter doesn't represent the amplitude of the
>> signal, but the amplitude^5 (fifth power). That makes it hard to use
>> 2) The call returns a float, but it should really be an int
>> (spx_int32_t) so that it can work easily with fixed-point code
>>
>> There's a last minor thing: instead of SPEEX_PREPROCESS_GET_LOUDNESS, it
>> should be called SPEEX_PREPROCESS_GET_AGC_LOUDNESS. If you can send me a
>> patch that addresses these issues, I'll gladly apply it.
>>
>>     Jean-Marc
> 
> Hello Jean-Marc,
> 
> I made the changes you requested.  Please see the attached patch.
> Is this what you had in mind?
> 
> Mihai
> 


More information about the Speex-dev mailing list