[Speex-dev] Please test upcoming release

[Jean-Marc Valin]

Hi Jim,

Actually, I don't see anything wrong with the internal structure having
a different type than the interface, as long both types are big enough
to hold the possible values (in this case 0 and 1). Though, as you
pointed out, testenc needs to be fixed to use spx_int32_t instead of
int. I'll change that.

	Jean-Marc

Jim Crichton a écrit :
> st->highpass_enabled is typed inconsistently.  It is "int" in the
> structure, but "spx_int32_t" in the SET, GET cases in
> nb(sb)_encoder(decoder)_ctl.  The parameter is "int" in testenc.c, and
> in the TI version ti\testenc-TI-C5x.c. This breaks for 16 bit platforms,
> where "int" is 16 bits.
> 
> The types in the state structure and the _ctl routines really should
> match. For now, I have changed testenc-TI-C5x.c to pass a 32-bit
> parameter, which works with no change elsewhere.  I can send a patch for
> this.
> 
> Another inconsistency is that GET_COMPLEXITY returns a spx_int32_t, but
> the field st->complexity is an int.
> 
> - Jim
> 
> _______________________________________________
> Speex-dev mailing list
> Speex-dev at xiph.org
> http://lists.xiph.org/mailman/listinfo/speex-dev
>