[Speex-dev] Unifying fixed point and floating point

[Nic Roets]

I've been browsing around the speex-1.10 source tree.

Firstly I see 'float' is still used in many places. Can't we change them all to the appropriate type (spx_wordxx_t or similar) defined in arch.h ?

Secondly I see there is a lot of duplication regarding real-valued constants. One way would be to say:
#ifndef FIXED_POINT
#define CONSTANT(x) (x)
#else
#define CONSTANT(x) ((int)((x)*16384.0 + 0.5))
#endif
and then use the macro appropriately.

This would assume that all the compilers we intent to support has the ability to evaluate constant expressions at compile time. In my experience this assumption is reasonable.

Regards
-n
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.xiph.org/pipermail/speex-dev/attachments/20050918/02c7471e/attachment.htm