<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META http-equiv=Content-Type content="text/html; charset=iso-8859-1">
<META content="MSHTML 6.00.2900.2722" name=GENERATOR>
<STYLE></STYLE>
</HEAD>
<BODY bgColor=#ffffff>
<DIV><FONT face=Arial size=2>I've been browsing around the speex-1.10 source
tree.</FONT></DIV>
<DIV><FONT face=Arial size=2></FONT> </DIV>
<DIV><FONT face=Arial size=2>Firstly I see 'float' is still used in many
places. Can't we change them all to the appropriate type (spx_wordxx_t or
similar) defined in arch.h ?</FONT></DIV>
<DIV><FONT face=Arial size=2></FONT> </DIV>
<DIV><FONT face=Arial size=2>Secondly I see there is a lot of duplication
regarding real-valued constants. One way would be to say:</FONT></DIV>
<DIV><FONT face=Arial size=2>#ifndef FIXED_POINT</FONT></DIV>
<DIV><FONT face=Arial size=2>#define CONSTANT(x) (x)</FONT></DIV>
<DIV><FONT face=Arial size=2>#else</FONT></DIV>
<DIV><FONT face=Arial size=2>#define CONSTANT(x) ((int)((x)*16384.0 +
0.5))</FONT></DIV>
<DIV><FONT face=Arial size=2>#endif</FONT></DIV>
<DIV><FONT face=Arial size=2>and then use the macro appropriately.</FONT></DIV>
<DIV><FONT face=Arial size=2></FONT> </DIV>
<DIV><FONT face=Arial size=2>This would assume that all the compilers we
intent to support has the ability to evaluate constant expressions at compile
time. In my experience this assumption is reasonable.</FONT></DIV>
<DIV><FONT face=Arial size=2></FONT> </DIV>
<DIV><FONT face=Arial size=2>Regards</FONT></DIV>
<DIV><FONT face=Arial size=2>-n</FONT></DIV>
<DIV> </DIV></BODY></HTML>