[paranoia] Re: Cooked ioctl interface works with Linux ide-scsi, right?

[Jani Jaakkola]

On Tue, 13 Mar 2001, Jani Jaakkola wrote:

> and it worked. So my question is, have I found a bug in cdparanoia or is
> there some profound reason to not use cooked ioctl:ls with ide-scsi?

There was a catch. Linux kernel 2.2.18 has a bug when using CDROMREADAUDIO
ioctl with more than 8 audio blocks at a time. I posted a fix to
linux-kernel list, but in case anyone is interested, here is the very
trivial patch against drivers/cdrom/cdrom.c:

--- cdrom.c.orig	Wed Mar 14 13:15:13 2001
+++ cdrom.c	Wed Mar 14 15:42:19 2001
@@ -1946,6 +1946,7 @@
                         ra.buf += (CD_FRAMESIZE_RAW * frames);
                         ra.nframes -= frames;
                         lba += frames;
+			if (frames>ra.nframes) frames=ra.nframes;
                 }
                 kfree(cgc.buffer);
                 return ret;

--- >8 ----
List archives:  http://www.xiph.org/archives/
Paranoia homepage: http://www.xiph.org/paranoia/
To unsubscribe from this list, send a message to 'paranoia-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.