[opus] Misc patches

Jean-Marc Valin jmvalin at jmvalin.ca
Thu Jun 11 07:41:57 UTC 2020


Hi Marcus,

On 2020-06-08 01:39, Marcus Asteborg wrote:
>  1. Build test for cmake and run the test in gitlab-ci.
>  2. Disable the message box on Windows on abort that cause test hangs in CI.
>  3. Build time improvement by removing unnecessary includes of stdio.h
>     in production code and change to a lighter header intrin.h ->
>     intrin0.h (windows only). Attached screenshot of measurement but it
>     resulted in 14% buildspeed compared to master on Windows 64 debug
>     builds on my setup. As most improvements comes from change intrin.h
>     the impact on other platforms will not be that much.

I need to have a closer look, but patches 2 and 3 look pretty 
reasonable. For patch 1, can you explain a bit more what it does (to 
someone familiar with neither cmake nor gitlab-ci).

Cheers,

	Jean-Marc


More information about the opus mailing list