[opus] Antw: Re: [Patch] Non-diegetic support for channel mapping 254

Tue May 2 06:22:59 UTC 2017

>>> Jean-Marc Valin <jmvalin at jmvalin.ca> schrieb am 29.04.2017 um 02:22 in
Nachricht <450f2994-5731-04dc-f5cd-8f6ffbb6edc1 at jmvalin.ca>:
> On 28/04/17 07:54 PM, Drew Allen wrote:
>> sorry about that... extra lines... was it whitespace? If so, sorry about
>> that. 
> 
> No, that was worse than that. It broke all the builds. See the fix:
> https://git.xiph.org/?p=opus.git;a=commitdiff;h=a31e9fd24cd 

Just for curiosity: When you detected ithe patch is broken, wouldn't it have been preferrable to revert to the previous commit, asking for a new poatch rather than fixing the result of the patch?

Regards,
Ulrich

> 
> 	Jean-Marc
> _______________________________________________
> opus mailing list
> opus at xiph.org 
> http://lists.xiph.org/mailman/listinfo/opus 