[opus] Patches for adding 120 ms encoding
jmvalin at jmvalin.ca
Sat Jun 11 02:35:17 UTC 2016
I still need to look very carefully, which will take some time. That
being said, some comments I can already make:
1) You need to also update the multi-stream API.
2) You might want to check that CBR works for >60 ms encoding
On 06/10/2016 10:19 AM, Felicia Lim wrote:
> Hi, I wondered if are there any further thoughts on these patches?
> On Thu, Jun 2, 2016 at 2:13 PM Felicia Lim <flim at google.com
> <mailto:flim at google.com>> wrote:
> OK, I've amended the second patch and also added 80 and 100 ms.
> On Thu, Jun 2, 2016 at 7:20 AM Jean-Marc Valin <jmvalin at jmvalin.ca
> <mailto:jmvalin at jmvalin.ca>> wrote:
> On 06/01/2016 02:06 PM, Felicia Lim wrote:
> > That was my intention with refactoring out the subframe
> encoding and
> > repacketizing bit. Or do you mean I should merge the explicit
> check for
> > 120 ms frame and the existing checks for 40/60 ms wideband?
> What I mean is that this line in opus_encoder.c:
> if (frame_size > st->Fs/50 && (st->mode == MODE_CELT_ONLY ||
> st->bandwidth > OPUS_BANDWIDTH_WIDEBAND))
> can probably be extended to also cover 80/100/120 ms. One
> difference is
> that it would also need to trigger for SILK-only > 60 ms.
More information about the opus