[opus] [PATCH 1/1] Updated opus_types.h to correctly support 8 and 64 bit types.

Simon Jackson si at sonocent.com
Wed Jun 3 11:13:12 PDT 2015


Clearly I haven't thought these changes through properly and was only
really considering common desktop systems. I was originally fixing an issue
when compiling my code as 64bit where my use of int64_t (defined as long on
my platform) was conflicting with the opusfile stream callbacks (e.g.
op_seek_func) which were using the opus_int64 type which was defined as
long long. When I looked at the header I thought it could do with some
work, so instead of putting casts in my code, I modified the header and
sent a patch. I didn't even consider building for architectures which could
have a 40bit long etc. and am obviously a bit out of my depth in this case.

Sorry for the bad patch, please just disregard it. It might be worth
updating the header based on the ogg one though. Even without the breaking
changes I made, it seems to be much more update in some areas.


On 3 June 2015 at 17:59, Ralph Giles <giles at thaumas.net> wrote:

> On 2015-06-03 6:21 AM, Simon Jackson wrote:
> > - Replaced blanket #define of 8 & 64 bit types with typedefs for each
> >   platform to match 16 & 32 bit types.
> You didn't say why you need these additional types?
>  -r
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.xiph.org/pipermail/opus/attachments/20150603/21dbe28d/attachment-0001.htm 

More information about the opus mailing list