[ogg-dev] [PATCH] browser_plugin - kate support, build fixes, and misc

[ogg.k.ogg.k at googlemail.com]

> I've tried to separate out the general bugfixes from the new
> implementation work in this patch:

Sorry, I should have done that, I do tend to fix stuff I find while
coding and neglect splitting up afterwards. Bad me.

> I've not yet committed this to trunk. It does sound pretty cool
> though. I don't see any problem with adding pango etc. support, it's
> pretty much where we wanted to go for CMML handling anyway.

Ah, good. At the moment, it's still imlib2 only though. Not great
but will do for now. Cairo/Pango will be needed if/when I add my
rendering lib, but I'm just starting on it, so imlib2 it will be for the
near future.

If you have any comments/concerns about the Kate code, feel free
to comment. Especially on the Javascript API side (never done any
of this before).

> Let me know if this works for you or not; eg. it may be necessary to
> also put X_EXTRA_LIBS etc. in src/Makefile.am.

will try this.

> >   - bad pointer dereference fix (mouse callback)
>
> I couldn't find that particular hunk, could you please provide a patch
> which just fixes this?

Two hunks, the first one to initialize the mouse callback pointer
to NULL, and the second one to test for NULL before actually using it:

--- svn/annodex/browser_plugin/src/plugin.cpp   2008-04-04
15:14:28.000000000 +0100
+++ svn/annodex/browser_plugin-with-kate/src/plugin.cpp 2008-04-27
22:08:08.000000000 +0100
@@ -245,7 +244,8 @@
   mCmmlCallback(NULL),
   mAsyncCmmlCallback(NULL),
   mEndPlayCallback(NULL),
-  mPlaylistCallback(NULL)
+  mPlaylistCallback(NULL),
+  mMouseClickCallback(NULL)
 #if defined(XP_MACOSX)
   ,
   mOutputCleared(FALSE)
@@ -1037,7 +1175,9 @@

   if (mMouseButtonDown) {
     mMouseButtonDown = FALSE;
-    mMouseClickCallback->Call();
+    if (this->mMouseClickCallback != NULL) {
+      mMouseClickCallback->Call();
+    }
   }

   if (useSemaphore) {


> >   - avoid the input widget in test.html firing hotkey'd functions
>
> is this specific to the Kate changes? I noticed that it adds a focus
> tracking variable, but that seems to be used by some of the Kate UI
> also so I'm not sure if it's a general bugfix or Kate-specific.

Well, not really, more like only useful for the new kate test functions:
the keypress routine would be called for every keypress, but all
existing test routines would expect numbers in the input box, and no
numbers were hotkeys for any function, so nothing would get done.
Since I added a function (to see the font to use) that expects input
with other characters than numbers, some test functions would be
invoked.

However, looking at the patch, the input_focus variable isn't used
by the Kate UI. Were you talking about something else ?

Thanks for your time.