[ogg-dev] [PATCH] browser_plugin - kate support, build fixes, and misc

[Conrad Parker]

2008/4/29 ogg.k.ogg.k at googlemail.com <ogg.k.ogg.k at googlemail.com>:
>  > >   - bad pointer dereference fix (mouse callback)
>  >
>  > I couldn't find that particular hunk, could you please provide a patch
>  > which just fixes this?
>
>  Two hunks, the first one to initialize the mouse callback pointer
>  to NULL, and the second one to test for NULL before actually using it:
>
>  --- svn/annodex/browser_plugin/src/plugin.cpp   2008-04-04
>  15:14:28.000000000 +0100
>  +++ svn/annodex/browser_plugin-with-kate/src/plugin.cpp 2008-04-27
>  22:08:08.000000000 +0100
>  @@ -245,7 +244,8 @@
>    mCmmlCallback(NULL),
>    mAsyncCmmlCallback(NULL),
>    mEndPlayCallback(NULL),
>  -  mPlaylistCallback(NULL)
>  +  mPlaylistCallback(NULL),
>  +  mMouseClickCallback(NULL)
>   #if defined(XP_MACOSX)
>    ,
>    mOutputCleared(FALSE)
>  @@ -1037,7 +1175,9 @@
>
>    if (mMouseButtonDown) {
>      mMouseButtonDown = FALSE;
>  -    mMouseClickCallback->Call();
>  +    if (this->mMouseClickCallback != NULL) {
>  +      mMouseClickCallback->Call();
>  +    }
>    }
>
>    if (useSemaphore) {
>

thanks, merged in changeset:3573

>  > >   - avoid the input widget in test.html firing hotkey'd functions
>  >
>  > is this specific to the Kate changes? I noticed that it adds a focus
>  > tracking variable, but that seems to be used by some of the Kate UI
>  > also so I'm not sure if it's a general bugfix or Kate-specific.
>
>  Well, not really, more like only useful for the new kate test functions:
>  the keypress routine would be called for every keypress, but all
>  existing test routines would expect numbers in the input box, and no
>  numbers were hotkeys for any function, so nothing would get done.
>  Since I added a function (to see the font to use) that expects input
>  with other characters than numbers, some test functions would be
>  invoked.
>
>  However, looking at the patch, the input_focus variable isn't used
>  by the Kate UI. Were you talking about something else ?

nope, I was just unsure if it was independent of  the other kate stuff.

committed in changeset:3574

Conrad.