[ogg-dev] [PATCH] browser_plugin - kate support, build fixes, and misc

[Conrad Parker]

2008/4/28 ogg.k.ogg.k at googlemail.com <ogg.k.ogg.k at googlemail.com>:
> Hi,

Hi,

I've tried to separate out the general bugfixes from the new
implementation work in this patch:

>  this patch adds:
>
>   - kate support (what else) - this bumps the Javascript API to 1.1

I've not yet committed this to trunk. It does sound pretty cool
though. I don't see any problem with adding pango etc. support, it's
pretty much where we wanted to go for CMML handling anyway.

(btw. I'm tracking the Kate-specific stuff in a local git branch)

>   - a few build fixes

committed in changeset:3570

>  (note that the adding of -L/usr/X11/lib -lX11
>  looks suspect to me, that shouldn't be needed, so you may want to
>  leave it out if you think so as well - it's odd as X11 using programs
>  do configure fine on that box)

thanks for noticing, the configure script wasn't looking for the X11
install location at all. I've updated it to use the autoconf macro
AC_PATH_XTRA, which defines X_CFLAGS, X_LIBS etc. in changeset:3571

Let me know if this works for you or not; eg. it may be necessary to
also put X_EXTRA_LIBS etc. in src/Makefile.am.

>   - bad pointer dereference fix (mouse callback)

I couldn't find that particular hunk, could you please provide a patch
which just fixes this?

>   - avoid the input widget in test.html firing hotkey'd functions

is this specific to the Kate changes? I noticed that it adds a focus
tracking variable, but that seems to be used by some of the Kate UI
also so I'm not sure if it's a general bugfix or Kate-specific.

cheers,

Conrad.