[ogg-dev] [PATCH] liboggplay - kate support, build fixes, and misc
conrad at metadecks.org
Mon Apr 21 12:33:42 PDT 2008
On 21/04/2008, ogg.k.ogg.k at googlemail.com <ogg.k.ogg.k at googlemail.com> wrote:
> I've added kate support to liboggplay (a prerequisite to getting kate tracks
> to work with the mozilla plugin, which I've now got working on Linux).
> In addition to the Kate code:
> - a new oggplay-uninstalled.pc file
configure.ac:366: required file `oggplay-uninstalled.pc.in' not found
I think you forgot to include oggplay-uninstalled.pc.in in the patch :-)
> - configure.ac checks for C++ compiler
> - no check for fishsound version - it wanted 0.8.0, but the svn itself
> was 0.7.1 !?
sorry, my bad -- recent releases have been coming out of
The latest version is 0.9.1.
trunk is mostly up-to-date with that, and has some extra, incomplete, stuff.
(the liboggplay README does however specify the branch, just above the
line you added about Kate support ;-)
> - don't use imlib2 (nor dump-first-frame) if it isn't here (I didn't
> have this when I started hacking on liboggplay)
> - frob the CFLAGS/LIBS in Makefile.am to make it build for me (you
> want to look at this and only pick what seems correct to you, as I'm
> hazy on that one)
thanks, you added a missing $(FISHSOUND_CFLAGS) to src/liboggplay/Makefile.am
> - oggplay_set_track_inactive is now exposed in the API (I needed this
> to switch kate tracks
> on the fly in the browser plugin)
There seems to be some inconsistency in the changes to the type of
sample_in_record and its accessor: the field was changed from int to
ogg_int64_t in src/liboggplay/oggplay_callback_info.h, and the return
type of the accessor function was changed from int to long in the
corresponding .c file and public header.
I've committed (in changeset:3561) everything except:
- the changes which reference oggplay-uninstalled.pc
- removal of the fishsound version check
- the changes to the type of sample_in_record
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 1985 bytes
Desc: not available
Url : http://lists.xiph.org/pipermail/ogg-dev/attachments/20080422/92d53b06/attachment.bin
More information about the ogg-dev