[ogg-dev] [PATCH] liboggplay - kate support, build fixes, and misc

ogg.k.ogg.k at googlemail.com ogg.k.ogg.k at googlemail.com
Tue Apr 22 02:03:26 PDT 2008

> configure.ac:366: required file `oggplay-uninstalled.pc.in' not found
> I think you forgot to include oggplay-uninstalled.pc.in in the patch :-)

Ahem. I must have. I'll send it when I reach my dev machine.

> (the liboggplay README does however specify the branch, just above the
> line you added about Kate support ;-)

Ah, OK. I already had liboggplay svn around from before, so I didn't
think of checking this.

> There seems to be some inconsistency in the changes to the type of
> sample_in_record and its accessor: the field was changed from int to
> ogg_int64_t in src/liboggplay/oggplay_callback_info.h, and the return
> type of the accessor function was changed from int to long in the
> corresponding .c file and public header.

Yes, the reason is that all the routines here return a long (I presume so
they can be used from Python ?) so that's what I did here. However, the
number of samples (here, for me, granules) is an ogg_int64_t, so that's
what I put on the structure. Would you settle on long or ogg_int64_t ?

While there, a couple questions about the mozilla browser plugin, since
this is an annodex project:

- would you welcome kate support here too ?
- would additional optional dependencies beyond libkate be OK (I have
  none at the moment, but I'm thinking of fontconfig, and maybe later
  pango and cairo, though this is more long term)
- I've added new Javascript APIs to handle kate streams, and bumped
  the API version to 1.1 - is there anything I need to be aware of that
  might break with this API change ? Works fine here in a controlled
  environment (firefox, streaming from icecast).
- it seems to say it handles "application/liboggplay", but AFAIU, it can
  understand all ogg streams (and isn't annodex "application/annodex"
  anyway ?) so shouldn't that be changed to "application/ogg" ? I know
  my test stream is a plain Ogg stream, and it works fine.
- and would a patch be accepted if there was no implementation of the
  kate code for mac and windows ?


More information about the ogg-dev mailing list