[icecast-dev] More libshout questions ((even)more info)

Michael Smith msmith at xiph.org
Mon Jan 19 20:17:05 PST 2004

On Tuesday 20 January 2004 14:57, Deven Phillips wrote:
> Michael,
> 	I was looking through the source code last night, and libshout-2.x does
> do URL encoding of the key/value pairs for metadata. Have a look at
> shout.c:308, util.c:247, and util.c:139. I looked at the "safechars"
> array, and from what I can figure (straight ASCII table right?), "-"'s
> are URL encoded when they don't need to be. When I changed that array,
> recompiled, and ran; everything worked out fine.

In the remote-metadata-update function, (shout_set_metadata(), yes. I thought 
you were talking about the HTTP headers (as my email made clear). 

It's never unsafe to URL-encode additional characters, so it's not clear what 
change you're trying to make, and why.


--- >8 ----
List archives:  http://www.xiph.org/archives/
icecast project homepage: http://www.icecast.org/
To unsubscribe from this list, send a message to 'icecast-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.

More information about the Icecast-dev mailing list