[icecast-dev] More libshout questions ((even)more info)

[Deven Phillips]

Michael,

        I was looking through the source code last night, and libshout-2.x does
do URL encoding of the key/value pairs for metadata. Have a look at
shout.c:308, util.c:247, and util.c:139. I looked at the "safechars"
array, and from what I can figure (straight ASCII table right?), "-"'s
are URL encoded when they don't need to be. When I changed that array,
recompiled, and ran; everything worked out fine.

Deven Phillips, CISSP

On Mon, 2004-01-19 at 14:53, Michael Smith wrote:
> On Monday 19 January 2004 23:04, Deven Phillips wrote:
> > Even more to consider...
> >
> >     The metadata is working with WinAmp and RealPlayer. The concern I
> > have is that the 'url' metadata is being misinterpreted. My url has a
> > "-" in it, and that is getting mistranslated somewhere and
> > WinAmp/RealPlayer then see it as artist/title information.  Not good.
> > WinAmp is supposed to display the website defined by the URL. Something
> > else I'll be looking into. Perhaps libshout does/doesn't do some URL
> > encoding?
> >
> 
> libshout does not do url encoding for header values. If your client (winamp) 
> has bugs requiring it to be encoded in this case, then you should do the 
> encoding on the calling side.
> 
> Mike
> 
> --- >8 ----
> List archives:  http://www.xiph.org/archives/
> icecast project homepage: http://www.icecast.org/
> To unsubscribe from this list, send a message to 'icecast-dev-request at xiph.org'
> containing only the word 'unsubscribe' in the body.  No subject is needed.
> Unsubscribe messages sent to the list will be ignored/filtered.

--- >8 ----
List archives:  http://www.xiph.org/archives/
icecast project homepage: http://www.icecast.org/
To unsubscribe from this list, send a message to 'icecast-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.