[icecast-dev] icecast 2 auth problem with (old?) ices, MuSe

[Michael Smith]

On Tuesday 13 January 2004 03:04, Mihai RUSU wrote:
> Hi
>
> I have recently downloaded icecast 2 (I am an old icecast 1.x user) and
> tried to use it with my ices 0.2.3 (which works on icecast 1) but fails on
> login. Also I have tried with MuSe 0.8.1 and same error too. After some
> digging into the sources I found the problem to be with _check_pass_icy()
> which receives a "strange" pass to compare with, something like this
> "SOURCE <password> /<mountpoint>" and it does strcmp on this with the
> configured pass in icecast.xml which, of course, fails.
>
> Now this either is because of some protocol changes you guys did into
> icecast 2 and im using old version tools , or the calling code of
> _check_pass_icy() should parse a little more the string before feeding it
> up to _check_pass_icy(), in any case I did the following dirty/fast patch
> which works for me(tm):
>

This shouldn't be being passed to _check_pass_icy() at all - this isn't the 
"icy" (shoutcast nasty ugly) protocol at all. We support that (icy) protocol 
because it's widely used - but it's a horribly ugly hack to pretend that it's 
HTTP-like. We're not adding more not-HTTP-but-somewhat-similar protocols.

In fact, it's not any of the protocols supported by icecast.

The only bug here is that httpp_parse_icy() is accepting this request, so it 
later gets passed to _check_pass_icy() - but httpp_parse_icy() _should_ do 
more error checking and reject this entirely. 

Mike

--- >8 ----
List archives:  http://www.xiph.org/archives/
icecast project homepage: http://www.icecast.org/
To unsubscribe from this list, send a message to 'icecast-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.