[flac-dev] flac 1.3.0pre3 pre-release
lrn1986 at gmail.com
Mon Apr 1 05:29:52 PDT 2013
-----BEGIN PGP SIGNED MESSAGE-----
On 01.04.2013 16:24, Janne Hyvärinen wrote:
> I'm worried about some of the modifications done to the UTF-8
> patch. In commit 2199d086921eb37d249cae0731f334556ec6209d #ifdef
> checks were changed from specific FLAC__STRINGS_IN_UTF8 to generic
> _WIN32 and the specific defines were later removed in commit
> The reason I had them this way is that FLAC API has public
> functions that work with filenames. Default compile options for
> FLAC would be unaffected and existing programs that rely on ANSI
> filenames would continue to work. The new configuration option
> "Release (UTF-8)" was meant to isolate the changes so that only
> official bundled frontends that know about the changes would use
That's a valid point.
Alternative approach (something i saw in libxml2 recently) is to make
UTF-8-to-UTF-16 conversion a bit smarter:
First try the conversion, assuming the string to be UTF-8-encoded.
If that fails, assume the string is in native encoding, and run the
conversion function again with appropriate source codepage (when using
W32 conversion functions that would be CP_ACP).
If that fails, fail the function call as usual.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
-----END PGP SIGNATURE-----
More information about the flac-dev