[vorbis] Unicode on Win32

[Peter Harris]

Michael Smith wrote:
> On Tuesday 08 July 2003 03:05, Peter Harris wrote:
>>http://bugs.xiph.org/show_bug.cgi?id=268
>>
>>Good? Bad? Ugly? Anything would be better than simply being ignored.
> 
> Ugly. It pushes character set handling throughout the application in a messy 
> way, just in order to deal with broken stuff on windows.

Hmm. When you put it that way, it is rather ugly.

Some of the ugliness is from supporting '--utf8' (like vorbiscomment's 
'--raw', but --raw was already being used for something else), but I 
can't justify all of it.

> It's also enormously 
> complex and obviously quite version-specific (an unfortunate fact is that a 
> lot of windows users are still using 9x.)

Okay, it doesn't change the (broken) way oggenc operates on 9x. But that 
is because 9x is fundamentally broken with respect to Unicode, so there 
isn't much we could have done to improve things.

Besides, the NT-specific stuff is clearly marked. I don't have a 9x 
machine any more; I was hoping someone who does could pitch in (if 
indeed there is any benefit to imrpoving 9x, given the fundamental 
brokenness of the OS.)

At this point, I'm open to suggestions. I don't mind rewriting the way 
my patch works, but oggenc (and vorbiscomment) definitely need some 
patch; the way they work on Win32 right now is simply broken.

How do you think oggenc should handle UCS-16 command lines?

Peter Harris

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.