[vorbis] Oggdrop XPd don't support Unicode ?

[Nathan I. Sharfi]

On Thu, 23 Jan 2003, Peter Harris wrote:

> John Edwards wrote:
> > oggdropXPd, like oggenc, supports UTF8 and, in fact, uses the same routines
> > as oggenc.
>
> Ewwwwwwwwww.
>
> As it stands in CVS, oggenc is horribly, badly, terribly broken on
> Windows with respect to UNICODE.
>
> See my patch
> http://www3.sympatico.ca/ix42/oggenc.unicode.patch.gz
>
> which is referenced from
> http://bugs.xiph.org/show_bug.cgi?id=268
>
> I have received zero feedback on this patch, good or bad. I would
> appreciate anything anybody could say about this patch.
Regarding
+/* presume that people aren't going to put utf8 filenames on the command
line. */
+/* Is this a valid presumption? */
+#define oggenc_fopen(x,y,z) fopen(x,y)
+#define get_args_from_ucs16(x,y,z) { }
+
+#endif

I'm not exactly sure that I understand you correctly, but I think it's a
mistake to assume that all filenames will be 7-bit-ASCII-compatible.

(I figure I'm ignoring a bunch of corner cases where raw UTF-8 is being
passed to a UTF-16LE by some mechanism other than cut 'n paste into
cmd.exe.)

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.