[Vorbis-dev] oggdec not freeing memory when outfilename is not specified.

Michael Smith msmith at xiph.org
Wed Jun 7 01:53:30 PDT 2006


On 6/7/06, Tahseen Mohammad <tahseen.mohammad at gmail.com> wrote:
> Index: oggdec/oggdec.c
> ===================================================================
> --- oggdec/oggdec.c     (revision 11531)
> +++ oggdec/oggdec.c     (working copy)
> @@ -409,6 +409,8 @@
>              if(!infile)
>                  return 1;
>              outfile = open_output(out);
> +           if (!outfilename)
> +                   free(out);
>              if(!outfile) {
>                  fclose(infile);
>                  return

Thanks, I committed this with the free moved a few lines further down,
so that it doesn't get used after freeing.

Mike


More information about the Vorbis-dev mailing list