[Vorbis-dev] Re: vcedit/vorbiscomment heterogeneous streams

Ian Malone ibmalone at gmail.com
Fri Feb 24 16:44:54 PST 2006


Ian Malone wrote:
> Hi,
> 
> The following changes allow vorbiscomment to read and edit the
> tags for the first occuring vorbis stream in a muxed (and
> chained) Ogg bitstream, while retaining the renormalisation.
> 
> I've tested it on a number of combinations of muxed and chained
> streams, using the write comments from file option for
> vorbiscomment to rewrite the comment header and then cmp for
> binary differences.  Seems to work so far.
> 

As I mentionned in the other email, the previous set of patches
didn't include some error checks[1].  This patch to be applied on
top fixes that (don't want to clog mailboxes with two copies of
the first set).  I'll put the combined set up on
<www.srcf.ucam.org/~ibm21/omd_links/> later.

[1]  Failure to check whether buffer pushes succeeded, failure
    to check new link insertion, failure to check whether a
    supported stream was found.
-- 
imalone
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vorbiscomment.imalone_1-2.diff
Type: text/x-patch
Size: 5005 bytes
Desc: not available
Url : http://lists.xiph.org/pipermail/vorbis-dev/attachments/20060225/40adae29/vorbiscomment.imalone_1-2.bin


More information about the Vorbis-dev mailing list