[Vorbis-dev] vorbiscomment, ogg123 charset bug - ticket #685

[Gene Pavlovsky]

here it is. i test it this way. i don't have CHARSET set, my LC_CTYPE=ru_RU.UTF-8
i run vorbiscomment -w -t 'something=РУССКИЙ' (something=RUSSIAN in russian) test.ogg (where test.ogg is an existing file),
the vorbiscomment -l test.ogg; ogginfo test.ogg; everything works - i see russian characters. unpatched version yields '#' instead of them.

Conrad Parker wrote:
> On Mon, Sep 26, 2005 at 12:36:09PM +0400, Gene Pavlovsky wrote:
> 
>>Hi
>>
>>I've a bug in vorbis-tools's libutf8 - some share/*.[ch] files don't include config.h; as a result, utf8.c:convert_set_charset doesn't try charset = nl_langinfo(CODESET) which would correctly return UTF-8, because HAVE_LANGINFO_CODESET isn't defined (it's defined in config.h, but config.h is not included). So, the bugfix is simple - just include config.h everywhere where it's missing.
>>
> 
> 
> do you have a patch? (it's probably faster to apply and test a patch than
> to replicate your work :-)
> 
> Conrad.
> 

-- 
The human knowledge belongs to the world
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vorbis-tools-1.1.1-config_h.patch
Type: text/x-patch
Size: 1367 bytes
Desc: not available
Url : http://lists.xiph.org/pipermail/vorbis-dev/attachments/20050927/a11c659d/vorbis-tools-1.1.1-config_h.bin