[Vorbis-dev] vorbiscomment, ogg123 charset bug - ticket #685

Conrad Parker conrad at metadecks.org
Tue Sep 27 03:17:22 PDT 2005


On Mon, Sep 26, 2005 at 12:36:09PM +0400, Gene Pavlovsky wrote:
> Hi
> 
> I've a bug in vorbis-tools's libutf8 - some share/*.[ch] files don't include config.h; as a result, utf8.c:convert_set_charset doesn't try charset = nl_langinfo(CODESET) which would correctly return UTF-8, because HAVE_LANGINFO_CODESET isn't defined (it's defined in config.h, but config.h is not included). So, the bugfix is simple - just include config.h everywhere where it's missing.
> 

do you have a patch? (it's probably faster to apply and test a patch than
to replicate your work :-)

Conrad.


More information about the Vorbis-dev mailing list