[vorbis-dev] Bride of vorbisfile questions

[John Morton]

On Tuesday 16 December 2003 14:21, Michael Smith wrote:

>  This is a serious bug; vorbisfile should either return errors on opening
> such files, or (at least) errors on accessing that logical stream in such a
> file. We should fix this for 1.0.2. You seem to have to looked at this in
> some detail, any chance of a patch?

I tried a workaround of doing a ov_read_float on each stream in the hope of 
getting an OV_EBADLINK for the oggflac stream, but it segfaults. I can pick 
out the bad stream by the serialnumber (which happens to be zero for my test 
case; no idea how consistant that will be, yet), but ov_read_float ends up 
segfaulting when it gets to the end of the preceding stream and updates 
'bitstream' to the new link number.

So, I'll try to come up with a simple test program and stream, and put 
something in bugzilla for yourself or some other vorbis guru to look at. 

Of couse it may not be easy (from an API/ABI compatability point of view) to 
work around this, so I'll look at patching _ov_read2 to check later logical 
streams with an eye to failing if any of them are bad. But hopefully we can 
just set those lstreams vi and vc structs to NULL and have ov_read quitely 
skip over bad logical streams. 

John

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.