[vorbis-dev] [PATCH] make vorbis work with KDE 3.0

[Michael Smith]

At 10:45 AM 3/18/02 +0100, you wrote:
>
>
>Hello,
>
>the appended Patch makes vorbis work on KDE 3.0.(again)
>
>A seek on a closed stream segfault vorbis, unfortunately
>this situation happens in the KDE Multimedia player
>very frequently (threads), thus vorbis does not work with KDE 3.0.
>
>The bug is that the goto seek_error calls in ov_pcm_seek_page
>do not set the return value in the error case.
>
>Monty, can you apply this?

Though there may be (it looks like there is) a bug here, this
fix is definately incorrect (you've changed it to return the
wrong error code - which in the buggy cases is better than no
error code, admittedly). I'll take a closer look and see
if I can fix it properly.

Your reasoning doesn't entirely make sense, in that the 
goto seek_error calls are never reached if the stream has
been closed (as you say it has been in this case). Sounds
like there's a nasty bug in your multimedia player as well.

Can you file this bug at http://bugs.xiph.org (bugzilla),
this'll ensure it gets fixed before the next release, otherwise
reports like this often get lost.

Michael

<p>--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.