[vorbis-dev] [PATCH] make vorbis work with KDE 3.0

[Martin Vogt]

Hello,

the appended Patch makes vorbis work on KDE 3.0.(again)

A seek on a closed stream segfault vorbis, unfortunately
this situation happens in the KDE Multimedia player
very frequently (threads), thus vorbis does not work with KDE 3.0.

The bug is that the goto seek_error calls in ov_pcm_seek_page
do not set the return value in the error case.

Monty, can you apply this?

The bug was introduced by the new search algo:
  /* new search algorithm by HB (Nicholas Vinen) */

regards,

Martin

RCS file: /usr/local/cvsroot/vorbis/lib/vorbisfile.c,v
retrieving revision 1.59
diff -u -r1.59 vorbisfile.c
--- lib/vorbisfile.c    2002/03/07 03:41:03     1.59
+++ lib/vorbisfile.c    2002/03/18 09:36:43
@@ -1175,6 +1175,7 @@
   /* dump machine so we're in a known state */
   vf->pcm_offset=-1;
   _decode_clear(vf);
+  ret=OV_ENOSEEK;
   return ret;
 }

<p>--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.