[vorbis-dev] bug in vorbisfile with threads

[Warren Spits]

Hello,

IMHO opinion the errno check should be removed. I believe it is a false
assumption that the read callback uses the errno. Especially when the
callback uses non-unix file IO such as in memory buffers or win32 file
functions.

A solution, that would break binary compatibility, is to use an ferror()
type callback function.

Warren.

----- Original Message -----
From: "Martin Vogt" <mvogt at rhrk.uni-kl.de>
>
>It looks like, that the bug with the errno variable
>cannot be solved in a:
>
>i)  binary compatible
>ii) source compatible
>
>way.(when we leave the errno check in)
>
>I can prepare such a patch, but this breaks everything.
>Not fixing this bug would mean the vorbisfile is not
>re-entrant.
>
>Another solution:
>-----------------
>
>Another way to fix the race is to remove the errno check
>completely. (I really prefer this solution.)
>

_________________________________________________________________
Get your FREE download of MSN Explorer at http://explorer.msn.com/intl.asp

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.