[vorbis-dev] longs

Firelight Multimedia support at fmod.org
Mon Sep 11 14:41:47 PDT 2000



oh ok i didnt know you were letting ints become 16bit values, surely there
are ints in the code that could overflow 16bits?
which machines supported are 16bit btw and have they been tested?  what are
they? atari-ST? amiga? they hardly even seem relevant and couldnt even
decode ogg vorbis in realtime.  (heh do they even support double).  Newer
mips platforms are more important with 64bit ints etc.. like you said more
typedefs would help i guess, but its a dumb idea to go to lengths to support
legacy hardware.

cheers
Brett

>
> > Please change all longs to int, and never use them in the future
>
> Pardon me for being blunt, but 'no'.  That breaks far more than it fixes.
>
> > They arent needed as on most platforms they are the same size. (which is
the assumption made in the ogg code anyway)
>
> Not true.
>
> > The reason for this is i will have vorbis support on playstation 2, but
long is 64 bits, and they are excruciatingly slow.
>
> On some platforms, int is 16 bits, and this would break the code badly.
It's
> true that my usage of long/int is slightly sloppy (I do use longs in many
> unneccessary places) but there are just as many places where using int
will
> break things.  We'll need to work a bit harder on a solution; the only
> reliable solution may well be to hardwire more Ogg types in autoconf...
>
> Monty
>
>
>
> --- >8 ----
> List archives:  http://www.xiph.org/archives/
> Ogg project homepage: http://www.xiph.org/ogg/
> To unsubscribe from this list, send a message to
'vorbis-dev-request at xiph.org'
> containing only the word 'unsubscribe' in the body.  No subject is needed.
> Unsubscribe messages sent to the list will be ignored/filtered.
>

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.



More information about the Vorbis-dev mailing list