[vorbis-dev] ao/

[Kenneth Arnold]

On Sat, Sep 30, 2000 at 12:48:23AM -0700, Ralph Giles wrote:
> Well, I wrestled with the automake stuff for a few hours, but basically
> came back to where I started. The problem is conditional compilation of
> the drivers. The current method tries to add them to the SOURCES line
> through an autoconf substitution, but that's ignored by the dependency
> generation. The docs suggest that we're supposed to generate an object
> list and pass it through LTLIBOBJS or some such, but I couldn't get it to
> work from that side either.
> 
> I'm beginning to suspect an automake bug. I know you can do substitution
> on SUBDIRs, and the docs claim to automagically support AC_REPLACE_FUNCS.
> Anybody know a work around?

I was beginning to suspect the same... infos on automake say that if the
x_SOURCES line is configure-dependant, all you have to do is put all possible
files in EXTRA_x_SOURCES and the dependencies will work out okay... but
obviously it is not doing that for me. I ran make with -d and it was looking
to make e.g. .deps/ao_alsa.c.P if I can remember right, or something like that,
suggesting that it had meant to make the dependencies for those but failed
("Failing remaking ao_alsa.c.P"). bug? or undocumented feature?

> Attached is some cleanup I did. apply the patch and unpack the tar file in
> the ao working directory and add the new files.

o you're not committing this yourself? (I haven't actually tried your patch
yet)

> * remove the include/ao/Makefile.am as unnecessary
>   unfortunately, we seem to be stuck with the include/ and doc/ makefiles
>   if we want to have the proper install paths.

looks ok

> * remove ao_libs.inc.in -- dead code

good I think...

> * add TODO to the distfiles

good

> * added a datestamp version number for development versions

good

> * removed the -$(VERSION) from the doc installpath

good

> * general configure.in cleanups.
>   add missing macros, remove unnecessary ones.
>   proper help lines for the driver switches

good :)

> * make driver switches go through config.h
>   move config.h include to audio_out.c where it belongs (not ao.h)

Yup. Brain fart (didn't realize that ao.h actually gets installed)

> A lot of that is worth applying, I think.
> 
> Cheers,
>  -ralph

Kenneth

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.