[vorbis-dev] ov_read bugfix (fwd)

[Monty]

Folks:

Granted, this slipped past my review too, but do *not* submit patches that 
have not been tested.  This bug was a no brainer; running the code only even 
once would have found it.

The mainline of Vorbis is our face to the world.  A simple mistake like this 
costs us credibility when we're already going to be fighting hard against some 
of the most powerful media organizations in the world.  We're in generally 
excellent shape on the code quality front-- I want us to stay that way.

I'm not pointing any fingers: I just want all of us to be properly careful.  
Testing new code is not suggested, it's required.

Monty

------- Begin Forwarded Message
[...]
From: "Mike Nordell" <tamlin at algonet.se>
To: <webmaster at xiph.org>
Subject: ov_read bugfix
Date: Sat, 13 May 2000 12:18:48 +0100

Sorry for possibly posting to the wrong address.

In vorbisfile.c, ov_read around line 1045 there's
  short *dest;
that's redefined inside the loop. The statement
  buffer=(char *)dest;
at around line 1057 and 1071 doesn't initialize buffer with anything
sensible, so SEGV and sorrow is likely to follow. :-)

I fixed it by just removing the (re) definition of 'dest' from within the
loops, though I don't know if it's the correct fix.

/Mike

------- End of Forwarded Message

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/