[vorbis-dev] Mainline nonportability

[volsung at asu.edu]

> I'd like to remind people with write access on the CVS mainline not to put any 
> tools/libs/patches into the main build that are not portable...  I'm getting 
> not-very-pretty flames from NetBSD folks because libao fails to *configure* 
> under NetBSD (let alone build), thus breaking building the build for the 
> entire CVS mainline.

Oops.  Sorry about that.  I've attached a patch (I'm the guilty author of the
code, but I don't have CVS access) that should fix the libao configure script
to never die like that.  libao still won't get compiled unless the user
uncomments that dir tree in the Makefile.in

> Actually, since we're on the subject, the core CVS module for Vorbis is 
> getting big and sprawling.  I'm thinking it may be time to start spinning off 
> the tools and plugins into other CVS modules in order to compartmentalize 
> maintainance of this kind of woe.

Sounds good. I really don't want to take down the tree again.  :)

Here's the patch:




Index: vorbis-tools/libao/configure
===================================================================
RCS file: /usr/local/cvsroot/vorbis/vorbis-tools/libao/configure,v
retrieving revision 1.1
diff -u -r1.1 configure
--- vorbis-tools/libao/configure	2000/07/22 01:57:05	1.1
+++ vorbis-tools/libao/configure	2000/07/28 14:40:40
@@ -1291,15 +1291,15 @@
 esac
 
 if test -z "$SIZE16"; then
-        { echo "configure: error: No 16 bit type found on this platform!" 1>&2; exit 1; }
+        echo "configure: warning: No 16 bit type found on this platform!" 1>&2
 fi
 if test -z "$SIZE32"; then
-        { echo "configure: error: No 32 bit type found on this platform!" 1>&2; exit 1; }
+        echo "configure: warning: No 32 bit type found on this platform!" 1>&2
 fi
 
 
 case $host in
-        *-*-linux*|*-openbsd*|*-freebsd*) 
+        *-*-linux*|*-openbsd*|*-freebsd*|*-netbsd*) 
                     LIBAO_OBJS="$LIBAO_OBJS ao_oss.o"
                     LIBAO_FLAGS="$LIBAO_FLAGS -DAO_COMPILE_OSS -DAO_DEFAULT=AO_OSS";;
         *-irix*)
@@ -1310,7 +1310,7 @@
                     LIBAO_OBJS="$LIBAO_OBJS ao_solaris.o"
                     LIBAO_FLAGS="$LIBAO_FLAGS -DAO_COMPILE_SOLARIS -DAO_DEFAULT=AO_SOLARIS";;
 
-        *) echo "$host is not currently supported by libao"; exit 1;;
+        *) echo "configure: warning: Native sound driver not supported for this operating system." 1>&2;;
 esac
 
 
Index: vorbis-tools/libao/configure.in
===================================================================
RCS file: /usr/local/cvsroot/vorbis/vorbis-tools/libao/configure.in,v
retrieving revision 1.1
diff -u -r1.1 configure.in
--- vorbis-tools/libao/configure.in	2000/07/22 01:57:05	1.1
+++ vorbis-tools/libao/configure.in	2000/07/28 14:40:40
@@ -85,17 +85,17 @@
 esac
 
 if test -z "$SIZE16"; then
-        AC_MSG_ERROR(No 16 bit type found on this platform!)
+        AC_MSG_WARN(No 16 bit type found on this platform!)
 fi
 if test -z "$SIZE32"; then
-        AC_MSG_ERROR(No 32 bit type found on this platform!)
+        AC_MSG_WARN(No 32 bit type found on this platform!)
 fi
 
 dnl --- Figure out which ao_* files to compile ---
 
 dnl Operating System Specific Files
 case $host in
-        *-*-linux*|*-openbsd*|*-freebsd*) 
+        *-*-linux*|*-openbsd*|*-freebsd*|*-netbsd*) 
                     LIBAO_OBJS="$LIBAO_OBJS ao_oss.o"
                     LIBAO_FLAGS="$LIBAO_FLAGS -DAO_COMPILE_OSS -DAO_DEFAULT=AO_OSS";;
         *-irix*)
@@ -106,7 +106,7 @@
                     LIBAO_OBJS="$LIBAO_OBJS ao_solaris.o"
                     LIBAO_FLAGS="$LIBAO_FLAGS -DAO_COMPILE_SOLARIS -DAO_DEFAULT=AO_SOLARIS";;
 
-        *) echo "$host is not currently supported by libao"; exit 1;;
+        *) AC_MSG_WARN(Native sound driver not supported by libao for this operating system.);;
 esac
 
 dnl ESounD

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/