[vorbis-dev] Re: libao api change

[Ralph Giles]

On Sun, 17 Dec 2000 09:11:03 -0700 (MST) volsung at asu.edu wrote:

> >   ao_append_option(&opts, "key", "value");
 
> I'm all for this one.  The original form of the function is really poor design
> on my part.  I hope this gets committed.

Thanks Stan. I've just committed the patches. Since this is an incompatible
change, I bumped both the library interface version and the package
version. However, I didn't update the .spec or debian/ files, so packagers
beware.

 -r

P.S. the original post seemingly didn't make it to the list. He's the text:

  Does anyone object to the attached patches? The main change is to be
  able to call

    ao_append_option(&opts, "key", "value");

  instead of passing the new option in a single "key:value" string. It
  appears to have been done this way for the convenience of ogg123's
  cmdline option parsing, but I think the separate strings make a lot more
  sense.

  I also cleaned up an ao_append_option() vs. ao_append_options()
  discrepancy between the library, its headers, and the documentation, and
  fixed an option leak in the append code, as well as some misc doc
  cleanups.

You can review the actual patches at http://www.xiph.org/archives/cvs/


--
giles at ashlu.bc.ca
where do we want to go today?

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.