[vorbis-dev] warnings

[Segher Boessenkool]

Firelight Multimedia wrote:
> 
> I remember a while back noting something about how many warnings
> ogg/vorbisfile and vorbis put out .. jack or monty asked for the warning
> listing but i just got the latest version and there seems to be just as
> many, maybe more!

Most of these are not using type postfixes on
(floating point) constants. Always write

a = 1e-3f;

if 'a' is float, etc. This will not help solve the
int64 stuff, 'cause we don't know what type the int64 is;
but we can typecast it.

I think MS C is a bit too picky about this issue, as it makes stuff
like

#define x (1.0)

impossible without warnings (if you don't know if it will be
assigned to float/double). But the warnings about the int64 are ok.

I'll get the cvs_latest tonight, and send a mega-patch. Having the
floating point constants be float i.s.o. double helps performance.

A second help: using logf(), sinf(), whateverf() i.s.o. log(), sin(),
whatever() helps quite a lot as well. But I'm afraid this is gcc only;
I'll put in a quick hack.

Dagdag,

Segher

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.