[Tremor] FW: [Patch] Fix crash on large comments on low memory targets

[Mike Giacomelli]

> Hi, how does this patch handle the fact that the large comment is  
> still fully buffered by the Ogg page code?  When I fixed this issue  
> [1] I had to use a much more complex method to avoid using all the  
> extra memory in the Ogg page reading code.  I don't see any of that in  
> your patch, so I assume all the large pages containing comments will  
> still be read into memory?
> 
> [1] http://lists.xiph.org/pipermail/tremor/2009-January/001554.html

You mean that it will still be copied from storage into memory during buffering?  This seems harmless enough to me given that it'll be promptly overwritten the next time the system rebuffers. 

Or do I misunderstand you?


_________________________________________________________________
Windows Live™: Keep your life in sync. 
http://windowslive.com/explore?ocid=TXT_TAGLM_WL_BR_life_in_synch_062009
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.xiph.org/pipermail/tremor/attachments/20090702/6faf3a53/attachment.htm