[theora-dev] Build warnings

Id Kong spam_receptacle_ at hotmail.com
Wed Mar 24 06:08:24 PDT 2010



	Thank you for bringing this up, Stuart!  I've been meaning to mention this but it slipped my mind...	The Theora project (and I think all the Ogg projects in general) generates a lot of warnings when compiled.  Obviously all these warnings turn out to describe harmless things but it's better to have a project with no warnings so that when a change is made and a warning for a real problem gets reported, it's not lost in a sea of irrelevant warnings...	The problem I had to solve was actually a little more serious than a mere warning.  In the code, there are a lot of local variable declarations like so:

int func() {	int local_var = local_var;
	// do stuff}

	I'm guessing that this self initialization trick is supposed to trick the compiler into not reporting an uninitialized variable for variables that are only conditionally used.  However, when compiled for MS Windows using VC 2005 in debug mode, these initializations fail runtime checks and consequently throw exceptions.  This is really irritating when trying to debug code using Theora.  I actually had to run through all the code changing these initializations to something the compiler preferred like simply zeroing them out.  It would be nice if the official code base simply did this to begin with...	Again, it would be nice if the various Ogg projects didn't report any warnings when compiled.  You could almost do this just by throwing some brackets and explicit casts in the code...
	Finally, and a little off topic, but considering the lack of comprehensive documentation and tutorials for the various Ogg APIs, it would be a good idea for the example code, which frankly act like reference implementations, to be a little more verbose.  Variable names like "vi," "vt," "vc" etc... help to confuse the reader and obfuscate the code.  They have no place in an example program...	Thank you... 		 	   		  
_________________________________________________________________
Take your contacts everywhere
http://go.microsoft.com/?linkid=9712959
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.xiph.org/pipermail/theora-dev/attachments/20100324/bf4d0208/attachment.htm 


More information about the theora-dev mailing list