[theora-dev] [RFC] theorarm-merge-branch diff for latest svn

Riccardo Magliocchetti riccardo.magliocchetti at gmail.com
Mon Aug 23 08:46:57 PDT 2010

[Robin, sorry if you are receiving this for the third time, have 
subscribed to the list because previous attempt haven't hit the list]


i took the liberty to port the theorarm-merge-branch to latest svn (used 
the git mirror actually). The changes already contains the fix Dave 
Milici posted to the list, plus it adds more fixes:

- some warnings about unused variables in lib/arm/ARMstate.c
- fixup of include path in lib/arm/*.s
- more relaxed configure.ac check to match debian on qemu vm
- some compile fixes for a change in struct that became an array, it was 
called v iirc

This is an RFC because there are two open issues:

- plain ./configure fails because png2theora fails to link with 
libtheora, i have no idea on how to fix the issue. So my tests has been 
done with ./configure --disable-encoder --disable-examples --disable-float

- something in the fast path for decoder is broken, in fact these fast 
paths are disabled in lib/decode.c via an undef. If you remove the undef 
you get a segfault, tried to get a core but i hadn't symbols so no idea 
where to start.

I don't know how the status of merging the code back in theora svn but i 
thought that a single patch would a lot simpler to test for the people 

Simple tests have shown a reduction of 30% in time for executing
./examples/video_dump mobile_itu601_i_422.ogg > /dev/null

The test file is available here [1] from theora test suite [2].


[1] http://v2v.cc/~j/theora_testsuite/mobile_itu601_i_422.ogg
[2] http://wiki.xiph.org/TheoraTestsuite

-------------- next part --------------
A non-text attachment was scrubbed...
Name: theorarm-to-git-8ec0d25c0f21c82f.diff
Type: text/x-patch
Size: 135096 bytes
Desc: not available
Url : http://lists.xiph.org/pipermail/theora-dev/attachments/20100823/a985f097/attachment-0001.bin 

More information about the theora-dev mailing list